fix(ci): consolidate LuaRocks publication to tag-triggered workflow - #37
Merged
Conversation
- Remove LuaRocks publication from release-please.yml (commented out) - Update publish.yml with verbose lx upload for better debugging - Standardize on ubuntu-24.04 across all workflows - Add explanatory comments about consolidation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates LuaRocks publication into a single workflow to fix JSON dependency issues and simplify CI/CD debugging.
Problem
The Release Please workflow (
release-please.yml) fails at the "Publish to LuaRocks" step becauseluarocks uploadrequires a system Lua JSON library (cjson,dkjson, orjson) that isn't installed on the Ubuntu runner. The backuppublish.ymlworkflow succeeds usinglx uploadwhich has built-in JSON handling.This creates:
luarocks uploadvslx upload)lx upload, cryptic errors inluarocks upload)Solution
release-please.yml(lines 77-82 commented out with explanation)publish.ymlthe sole LuaRocks publication point with verbose output for better debuggingubuntu-24.04across all workflowsChanges
.github/workflows/release-please.yml:runs-on: ubuntu-latest→ubuntu-24.04.github/workflows/publish.yml:--verboseflag tolx uploadcommand for better debuggingBenefits
lx uploadshows what's happeninglx uploadhas built-in JSON handlingubuntu-24.04Testing
just checkpasses (linting/formatting)Notes
publish.ymlworkflow triggers on version tags (v*.*.*) andworkflow_dispatchrelease-please.ymlworkflow still creates GitHub releases with binaries